change notification archive to use path param

navikt · May 15, 2024 · 63c148f · 63c148f
1 parent 0ff2a16
commit 63c148f
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 9 deletions.
diff --git a/packages/client/src/views/notifications.ts b/packages/client/src/views/notifications.ts
@@ -8,10 +8,8 @@ class ArchivableNotificaton extends HTMLElement {
         if (id) {
             this.querySelector("button")?.addEventListener("click", () =>
                 fetch(
-                    endpointUrlWithParams("/api/notifications/archive", { id }),
-                    {
-                        method: "POST",
-                    },
+                    endpointUrlWithParams(`/api/notifications/${id}/archive`),
+                    { method: "POST" },
                 ).then(() => {
                     this.parentElement?.remove();
                     logAmplitudeEvent(...analyticsEvents.arkivertBeskjed);

diff --git a/packages/server/src/server.ts b/packages/server/src/server.ts
@@ -37,11 +37,8 @@ app.get("/api/ta", async (c) => {
         throw result.error;
     }
 });
-app.post("/api/notifications/archive", async (c) => {
-    const id = c.req.query("id");
-    if (!id) {
-        return c.json({ error: "Missing id" }).status(400);
-    }
+app.post("/api/notifications/:id/archive", async (c) => {
+    const id = c.req.param("id");
 
     const result = await archiveNotification({
         cookie: c.req.header("cookie") ?? "",