Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor #2809

Merged
merged 6 commits into from
Dec 18, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions cypress/e2e/fordeling/Annet.cy.js
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,7 @@ describe(`Fordeling ${dokumenttype}`, { testIsolation: false }, () => {

cy.get('[data-test-id="oppretteGosysOppgaveBtn"]').should('exist').should('not.be.disabled').click();

cy.get('[data-test-id="opprettIGosysOkModal"]').should('not.exist');
cy.get('[data-test-id="okGåTilLosModal"]').should('not.exist');

cy.get('[data-test-id="opprettIGosysFeil"]').should('exist');
});
Expand All @@ -63,10 +63,10 @@ describe(`Fordeling ${dokumenttype}`, { testIsolation: false }, () => {

cy.get('[data-test-id="opprettIGosysFeil"]').should('not.exist');

cy.get('[data-test-id="opprettIGosysOkModal"]').should('exist');
cy.get('[data-test-id="opprettIGosysOkModalInfo"]').should('exist');
cy.get('[data-test-id="opprettIGosysOkModalOKBtn"]').should('exist').click();
cy.get('[data-test-id="okGåTilLosModal"]').should('exist');
cy.get('[data-test-id="okGåTilLosModalInfo"]').should('exist');
cy.get('[data-test-id="okGåTilLosModalOKBtn"]').should('exist').click();

cy.get('[data-test-id="opprettIGosysOkModal"]').should('not.exist');
cy.get('[data-test-id="okGåTilLosModal"]').should('not.exist');
});
});
57 changes: 29 additions & 28 deletions src/app/components/ErDuSikkerModal.tsx
Original file line number Diff line number Diff line change
@@ -1,48 +1,49 @@
import React from 'react';

import { FormattedMessage } from 'react-intl';
import { Button } from '@navikt/ds-react';
import VerticalSpacer from './VerticalSpacer';
import { Button, Modal } from '@navikt/ds-react';
import VerticalSpacer from 'app/components/VerticalSpacer';

interface Props {
melding: string;
modalKey: string;
open: boolean;
submitKnappText: string;
extraInfo?: string;

onSubmit: () => void;
onClose: () => void;

extraInfo?: string;
}

const ErDuSikkerModal: React.FC<Props> = ({ melding, submitKnappText, onSubmit, onClose, extraInfo }: Props) => {
return (
<div className="modal_content">
const ErDuSikkerModal = ({ melding, modalKey, open, onSubmit, onClose, submitKnappText, extraInfo }: Props) => (
<Modal key={modalKey} onClose={onClose} aria-label={modalKey} open={open} data-testid="erdusikkermodal">
<Modal.Body>
<FormattedMessage id={melding} />
<VerticalSpacer sixteenPx />

{extraInfo && (
<div>
<VerticalSpacer sixteenPx />
<FormattedMessage id={extraInfo} />
</div>
)}
<div className="punch_mappemodal_knapperad">
<Button
size="small"
className="knapp1"
onClick={() => {
onSubmit();
onClose();
}}
type="button"
>
<FormattedMessage id={submitKnappText} />
</Button>

<Button variant="secondary" size="small" className="knapp2" onClick={() => onClose()}>
<FormattedMessage id={'skjema.knapp.avbryt'} />
</Button>
</div>
</div>
);
};
</Modal.Body>

<Modal.Footer>
<Button
size="small"
onClick={() => {
onSubmit();
onClose();
}}
>
<FormattedMessage id={submitKnappText} />
</Button>

<Button variant="secondary" size="small" onClick={() => onClose()}>
<FormattedMessage id="skjema.knapp.avbryt" />
</Button>
</Modal.Footer>
</Modal>
);

export default ErDuSikkerModal;
45 changes: 0 additions & 45 deletions src/app/components/ErDuSikkerModal2.tsx

This file was deleted.

28 changes: 11 additions & 17 deletions src/app/components/brev/BrevComponent.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ import { Formik, Form } from 'formik';
import { useNavigate } from 'react-router-dom';
import hash from 'object-hash';
import { FormattedMessage } from 'react-intl';
import { Alert, Button, ErrorMessage, Modal } from '@navikt/ds-react';
import { Alert, Button, ErrorMessage } from '@navikt/ds-react';
import { FileSearchIcon, PaperplaneIcon } from '@navikt/aksel-icons';
import { ApiPath } from 'app/apiConfig';
import BrevFormKeys from 'app/models/enums/BrevFormKeys';
Expand Down Expand Up @@ -173,23 +173,17 @@ const BrevComponent: React.FC<BrevProps> = ({
return (
<>
{!sendBrevUtenModal && (
<Modal
className="modalContainer"
key="erdusikkerpåatsendebrevmodal"
onClose={() => setVisErDuSikkerModal(false)}
aria-label="erdusikkerpåatsendebrevmodal"
<ErDuSikkerModal
melding="modal.erdusikker.sendebrev"
modalKey="erdusikkerpåatsendebrevmodal"
open={visErDuSikkerModal}
>
<ErDuSikkerModal
submitKnappText="modal.erdusikker.fortsett"
melding="modal.erdusikker.sendebrev"
onSubmit={() => {
setVisErDuSikkerModal(false);
handleSubmit();
}}
onClose={() => setVisErDuSikkerModal(false)}
/>
</Modal>
submitKnappText="modal.erdusikker.fortsett"
onSubmit={() => {
setVisErDuSikkerModal(false);
handleSubmit();
}}
onClose={() => setVisErDuSikkerModal(false)}
/>
)}

<Form>
Expand Down
53 changes: 0 additions & 53 deletions src/app/components/okGaaTilLosModal/OkGaaTilLosModal.tsx

This file was deleted.

64 changes: 64 additions & 0 deletions src/app/components/okGåTilLosModal/OkGåTilLosModal.tsx
Original file line number Diff line number Diff line change
@@ -0,0 +1,64 @@
import React from 'react';

import { FormattedMessage } from 'react-intl';
import { Button, Modal } from '@navikt/ds-react';
import CheckCircleSvg from '../../assets/SVG/CheckCircleSVG';
import { getEnvironmentVariable } from '../../utils';
import { initializeDate } from '../../utils/timeUtils';

import './okGåTilLosModal.less';

interface Props {
melding: string;
onClose: () => void;
}

const getDate = () => initializeDate().add(21, 'days').format('DD.MM.YYYY');

const utledMelding = (mld: string) => {
if (mld === 'modal.settpaavent.til') {
return <FormattedMessage id={mld} values={{ dato: getDate() }} />;
}
return <FormattedMessage id={mld} />;
};

const OkGåTilLosModal = ({ melding, onClose }: Props) => {
return (
<Modal
key="settpaaventokmodal"
onClose={onClose}
aria-label="settpaaventokmodal"
data-test-id="okGåTilLosModal"
open
>
<Modal.Body>
<div className="ok-gaa-til-los" data-testid="ok-gaa-til-los-modal">
<CheckCircleSvg title="check" />

<div className="vl" />

<div className="info" data-test-id="okGåTilLosModalInfo">
<div className="flex flex-wrap">{utledMelding(melding)}</div>

<div className="flex flex-wrap">
<FormattedMessage id="modal.okgaatillos.tillos" />
</div>
</div>

<Button
className="okknapp"
size="small"
onClick={() => {
window.location.href = getEnvironmentVariable('K9_LOS_URL');
}}
data-test-id="okGåTilLosModalOKBtn"
>
<FormattedMessage id="modal.okgaatillos.ok" />
</Button>
</div>
</Modal.Body>
</Modal>
);
};

export default OkGåTilLosModal;
26 changes: 0 additions & 26 deletions src/app/components/settPaaVentModal/SettPaaVentErrorModal.tsx

This file was deleted.

Loading
Loading