Legg til erstatningskey i melding for forespoersel-ID #772
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bjerga
commented
Nov 14, 2024
There was a problem hiding this comment.
Endringene i denne filen vil vi beholde, unntatt bruken av shouldContainAllExcludingTempKey .
bjerga
commented
Nov 14, 2024
Comment on lines
-292
to
+293
| ): Map<Key, Any> = | ||
| ): Map<Key, JsonElement> = |
There was a problem hiding this comment.
Denne endringen vil vi beholde.
bjerga
commented
Nov 14, 2024
Comment on lines
-28
to
+29
| Key.FORESPOERSEL_ID to fail.forespoerselId?.toJson(), | ||
| Key.FORESPOERSEL_ID to fail.forespoerselId.shouldNotBeNull().toJson(), |
There was a problem hiding this comment.
Denne endringen vil vi beholde.
|
Testet OK. |
This was referenced Nov 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Dette er innsats for å strømlinjeforme formatet på meldingsnøklene våre, der vi i gamle dager kjørte en "gjør hva du vil"-policy.
Denne PR-en tar for seg verstingen
FORESPOERSEL_ID, som har utstrakt bruk. Det legges til en ny key med nytt format i de meldingene der den gamle keyen er tilstede.Fordi vi har strenge tester (🥳) så tok jeg en snarvei for å ikke måtte manuelt endre en haug med tester. Snarveien besto av en
replace allpåshouldContainExactlyfor å bytte med den mer tilgiveligeshouldContainAllExcludingTempKey. Disse testendringene skal reverseres i neste PR.