Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ui: card - keep consistency with example-viewer #646

Closed
catlabs opened this issue Aug 31, 2018 · 0 comments · Fixed by #694
Closed

ui: card - keep consistency with example-viewer #646

catlabs opened this issue Aug 31, 2018 · 0 comments · Fixed by #694

Comments

@catlabs
Copy link
Contributor

catlabs commented Aug 31, 2018

I'm submitting a...


[ ] Regression (a behavior that used to work and stopped working in a new release)
[ ] Bug report  
[x] Feature request
[ ] Documentation issue or request
[ ] Support request => Please do not submit support request here, instead see https://github.com/NationalBankBelgium/stark/blob/master/CONTRIBUTING.md#got-a-question-or-problem

Current behavior

The header of the example-viewer card has a blue background while mat-card doesn't have any.

Expected behavior

Either all cards should have the same layout or we should define some classes. UX wise in the second case, we should agree on what type of behavior is behind each layout.

@catlabs catlabs added this to the 10.0.0-alpha.5 milestone Aug 31, 2018
@catlabs catlabs self-assigned this Aug 31, 2018
catlabs added a commit to catlabs/stark that referenced this issue Sep 13, 2018
catlabs added a commit to catlabs/stark that referenced this issue Sep 14, 2018
catlabs added a commit to catlabs/stark that referenced this issue Sep 14, 2018
catlabs added a commit to catlabs/stark that referenced this issue Sep 14, 2018
catlabs added a commit to catlabs/stark that referenced this issue Sep 14, 2018
catlabs added a commit to catlabs/stark that referenced this issue Sep 17, 2018
catlabs added a commit to catlabs/stark that referenced this issue Sep 17, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants