From 1a18506845fee8c4cc9d59e5d0e533843cfc4c7b Mon Sep 17 00:00:00 2001 From: Robbie Lyman Date: Thu, 6 Mar 2025 10:54:46 -0500 Subject: [PATCH] fix(build)!: update to zig 0.14.0 (#136) * fix(build)!: update to zig 0.14.0 BREAKING: this PR changes the package name from `ziglua` to `lua_wrapper`. not using `zig` in the package name has been repeatedly communicated as best practices, analogous to `npm`'s naming guidelines. for this particular package, this is complicated by the fact that `ziglua` provides far more than just `lua` packaged for Zig's build system (which already exists in numerous places), but also aims to provide ergonomic and powerful Zig abstractions on top of the Lua C implementation. For this reason, I chose to add "bindings" to the name. NB - the "fingerprint" field in build.zig.zon is new in Zig 0.14.0 and is computed in part based on the name. once we have settled on the name, if it is not "lua_wrapper" it will be necessary to delete the fingerprint line and regenerated it. * fix(ci): update build runners to zig 0.14.0 * package: lua_bindings -> lua_wrapper --- .github/workflows/docs.yml | 2 +- .github/workflows/tests.yml | 2 +- build.zig.zon | 3 ++- 3 files changed, 4 insertions(+), 3 deletions(-) diff --git a/.github/workflows/docs.yml b/.github/workflows/docs.yml index 883a278..281189a 100644 --- a/.github/workflows/docs.yml +++ b/.github/workflows/docs.yml @@ -27,7 +27,7 @@ jobs: uses: actions/configure-pages@v5 - uses: mlugg/setup-zig@v1 with: - version: 0.14.0-dev.3259+0779e847f + version: 0.14.0 - run: make docs - name: Upload artifact uses: actions/upload-pages-artifact@v3 diff --git a/.github/workflows/tests.yml b/.github/workflows/tests.yml index a8f0c66..cb95662 100644 --- a/.github/workflows/tests.yml +++ b/.github/workflows/tests.yml @@ -20,7 +20,7 @@ jobs: - name: Setup Zig uses: mlugg/setup-zig@v1 with: - version: 0.14.0-dev.3259+0779e847f + version: 0.14.0 - name: Run tests run: make test diff --git a/build.zig.zon b/build.zig.zon index c2fa235..c402704 100644 --- a/build.zig.zon +++ b/build.zig.zon @@ -1,5 +1,6 @@ .{ - .name = "ziglua", + .name = .lua_wrapper, + .fingerprint = 0xb40fd4eedb02233b, // changing this has security and trust implications .version = "0.1.0", .paths = .{ "build.zig", "build.zig.zon", "src", "license", "include", "build" },