Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HQ railroad raster sample data doesn't represent railroads #1146

Closed
dcdenu4 opened this issue Jan 9, 2023 · 2 comments · Fixed by #1667
Closed

HQ railroad raster sample data doesn't represent railroads #1146

dcdenu4 opened this issue Jan 9, 2023 · 2 comments · Fixed by #1667
Assignees
Labels
good first issue Good for new members of the software team task Something needs to be done

Comments

@dcdenu4
Copy link
Member

dcdenu4 commented Jan 9, 2023

In working on a threat decay issue with HQ I noticed that the railroad threat raster didn't match the railroad class in the LULC raster. It instead looks like the railroad threat raster is mimicking the residential LULC class.

The HQ sample data should be updated to fix this discrepancy which could influence the HQ tests.

@dcdenu4 dcdenu4 added good first issue Good for new members of the software team task Something needs to be done labels Jan 9, 2023
@dcdenu4 dcdenu4 self-assigned this Jan 9, 2023
@emilyanndavis emilyanndavis self-assigned this Oct 22, 2024
@emilyanndavis
Copy link
Member

@dcdenu4, I've updated the railroad threat rasters in the sample data repo.

I also ran invest-autotest and invest-autovalidate while pointing to the updated data locally and verified those tests passed.

I couldn't find any references to the sample data in the HQ model test suite (it seems to generating a lot—if not all—of its test data on the fly). Before I update the revision hash, could you double-check test_habitat_quality.py and make sure I'm not missing something obvious?

@emilyanndavis
Copy link
Member

Before I update the revision hash, could you double-check test_habitat_quality.py and make sure I'm not missing something obvious?

Actually, no need! I was able to pull the updated sample data and run all the model tests, and everything passed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for new members of the software team task Something needs to be done
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants