Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #101, Correct CFE_TBL_GetAddress return code check #117

Merged
merged 1 commit into from
Jan 21, 2021

Conversation

skliper
Copy link
Contributor

@skliper skliper commented Jan 6, 2021

Describe the contribution
Fix #101 - only status < CFE_SUCCESS is an error since CFE_TBL_GetAddress has multiple "success" codes

Testing performed
Built, ran, sent sample app process command to confirm it works

Expected behavior changes
Resolves bug where success code was reported as an error

System(s) tested on

  • Hardware: cFS Dev Server
  • OS: Ubuntu 18.04
  • Versions: Bundle main + this commit

Additional context
None

Third party code
None

Contributor Info - All information REQUIRED for consideration of pull request
Jacob Hageman - NASA/GSFC

@astrogeco astrogeco changed the base branch from main to integration-candidate January 21, 2021 16:50
@astrogeco astrogeco merged commit 865723a into nasa:integration-candidate Jan 21, 2021
@skliper skliper deleted the fix101-getaddress branch February 1, 2021 19:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Not correctly checking return code of CFE_TBL_GetAddress
2 participants