Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unit tests including ".c" file #144

Closed
jphickey opened this issue Dec 28, 2021 · 0 comments · Fixed by #137
Closed

Unit tests including ".c" file #144

jphickey opened this issue Dec 28, 2021 · 0 comments · Fixed by #137
Assignees
Milestone

Comments

@jphickey
Copy link
Contributor

The CF unit tests are using #include to wrap a .c file. For example:

#include "cf_crc.c"

This practice was determined to violate GSFC coding standards.

It is likely done this way such that the test can access "static" items in the source file. The preferred way is to simply declare the item in a header file so that unit test can access it more conventionally.

@jphickey jphickey self-assigned this Dec 28, 2021
@skliper skliper added this to the Draco milestone Jan 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants