Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: use environment variables instead of contexts in publish_to_pypi.yml #1647

Closed
MarcoGorelli opened this issue Dec 23, 2024 · 0 comments · Fixed by #1652
Closed

ci: use environment variables instead of contexts in publish_to_pypi.yml #1647

MarcoGorelli opened this issue Dec 23, 2024 · 0 comments · Fixed by #1652
Labels
ci good first issue Good for newcomers, but anyone is welcome to submit a pull request! high priority Your PR will be reviewed very quickly if you address this

Comments

@MarcoGorelli
Copy link
Member

MarcoGorelli commented Dec 23, 2024 •
edited
Loading

We should apply the same diff from https://github.com/pypa/packaging.python.org/pull/1765/files to our publish_to_pypi.yml file
@MarcoGorelli MarcoGorelli added good first issue Good for newcomers, but anyone is welcome to submit a pull request! ci high priority Your PR will be reviewed very quickly if you address this labels Dec 23, 2024
@Dhanunjaya-Elluri Dhanunjaya-Elluri mentioned this issue Dec 23, 2024
Merged
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
ci good first issue Good for newcomers, but anyone is welcome to submit a pull request! high priority Your PR will be reviewed very quickly if you address this
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

ci: improve publish ci to use env vars Dhanunjaya-Elluri/narwhals
1 participant
@MarcoGorelli