Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: type constructor_eager as ConstructorEager instead of Constructor #1013

Closed
MarcoGorelli opened this issue Sep 20, 2024 · 1 comment · Fixed by #1091
Closed

chore: type constructor_eager as ConstructorEager instead of Constructor #1013

MarcoGorelli opened this issue Sep 20, 2024 · 1 comment · Fixed by #1091
Assignees
Labels
good first issue Good for newcomers, but anyone is welcome to submit a pull request! tests

Comments

@MarcoGorelli
Copy link
Member

In here

Constructor: TypeAlias = Callable[[Any], IntoFrame]

we have Constructor

The task is here it to:

  • make ConstructorEager, with IntoDataFrame instead of IntoFrame
  • in tests that have constructor_eager: Any, use instead constructor_eager: ConstructorEager. You may need to import it, see other tests for examples
@MarcoGorelli MarcoGorelli added tests pydata-amsterdam-2024-sprint good first issue Good for newcomers, but anyone is welcome to submit a pull request! and removed pydata-amsterdam-2024-sprint labels Sep 20, 2024
@lucianosrp
Copy link
Member

I'll take this one if no one is on it 😊

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers, but anyone is welcome to submit a pull request! tests
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants