-
Notifications
You must be signed in to change notification settings - Fork 121
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: Use pandas, PyArrow, and Polars eager in the DataFrame docstring examples #1000
Comments
I can take a stab at making a PR for one of the functions (DataFrame to_pandas() ) |
I will try the DataFrame.to_csv() |
I worked on PR: #1207 |
Glad that the doc update for |
This is very much personal taste, but what would you think about rendering the different outputs via
|
@AlessandroMiola I like the tabbed output much more as well, but I think the issue was compatibility with doctest. If you manage to figure out how to have both, I am absolutely happy to move to such output rendering |
Ahh, right! I see, thanks @FBruzzesi |
In the docstrings example in https://narwhals-dev.github.io/narwhals/api-reference/dataframe/, we always show the output for pandas and Polars
We should instead:
If this is your first time submitting a pull request, please choose one function to start with, and only submit a pull request for that one function. You've got used to the process, feel free to submit changes for more functions together (e.g. in groups of 3-4 functions in the same PR)
Contributing guide: https://github.com/narwhals-dev/narwhals/blob/main/CONTRIBUTING.md
example PR: #1010
The text was updated successfully, but these errors were encountered: