Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove nni_timer #1729

Closed
gdamore opened this issue Dec 17, 2023 · 1 comment
Closed

remove nni_timer #1729

gdamore opened this issue Dec 17, 2023 · 1 comment

Comments

@gdamore
Copy link
Contributor

gdamore commented Dec 17, 2023

Once #1728 is implemented, there will not be any further consumers for nni_timer, and we should just remove it.

The timer has some serious scalability issues, and similar functionality can be obtained with nni_sleep_aio.

Shrinking the code size is a win too.
@gdamore
Copy link
Contributor Author

gdamore commented Dec 17, 2023

This also eliminates a thread we don't need. Which will make some folks happy.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@gdamore