Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OneWire going into endless loop when seaching devices #541

Closed
up-streamer opened this issue Nov 11, 2019 · 0 comments · Fixed by nanoframework/nf-interpreter#1501
Closed

Comments

@up-streamer
Copy link

Details about Problem

When three or more devices are connected to the bus, The FindNext() never returns false to indicate last device found. Causing the search looping until runs out of memory.

Target:

ESP-32 and STM32

Firmware image version:

1.4.0-preview
Worked before? If so, with which nanoFramework image version:
Not checked

Description

A clear and concise description of what the bug is.

Detailed repro steps so we can see the same problem

  1. Install three or more devices on the OneWire bus.

  2. Run FindFirst() and then loop thru FindNext() saving the devices found.

  3. Observe the loop never ends.

  4. While in loop, remove devices from the bus in order to leave only two. The loop will end and the devices ID will be saved.
    ...

Expected behaviour

When found the total amount of devices, the FindNext() should return false.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants