Skip to content

Commit dfbe390

Browse files
authored
fix read config cache (#600)
1 parent c11cbcc commit dfbe390

File tree

1 file changed

+9
-3
lines changed

1 file changed

+9
-3
lines changed

clients/config_client/config_client.go

+9-3
Original file line numberDiff line numberDiff line change
@@ -205,14 +205,20 @@ func (client *ConfigClient) getConfigInner(param vo.ConfigParam) (content string
205205
response, err := client.configProxy.queryConfig(param.DataId, param.Group, clientConfig.NamespaceId,
206206
clientConfig.TimeoutMs, false, client)
207207
if err != nil {
208-
logger.Infof("get config from server error:%v ", err)
208+
logger.Errorf("get config from server error:%v, dataId=%s, group=%s, namespaceId=%s", err,
209+
param.DataId, param.Group, clientConfig.NamespaceId)
210+
209211
if clientConfig.DisableUseSnapShot {
210212
return "", errors.Errorf("get config from remote nacos server fail, and is not allowed to read local file, err:%v", err)
211213
}
214+
212215
cacheContent, cacheErr := cache.ReadConfigFromFile(cacheKey, client.configCacheDir)
213-
if err != nil {
214-
return "", errors.Errorf("read config from both server and cache fail, err=%v", cacheErr)
216+
if cacheErr != nil {
217+
return "", errors.Errorf("read config from both server and cache fail, err=%v,dataId=%s, group=%s, namespaceId=%s",
218+
cacheErr, param.DataId, param.Group, clientConfig.NamespaceId)
215219
}
220+
221+
logger.Warnf("read config from cache success, dataId=%s, group=%s, namespaceId=%s", param.DataId, param.Group, clientConfig.NamespaceId)
216222
return cacheContent, nil
217223
}
218224
return response.Content, nil

0 commit comments

Comments
 (0)