fix(core): Aborting manual trigger tests should call closeFunction
#9980
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
n8n-assistant
bot
added
core
netroy
force-pushed
the
fix-NODE-1230-manual-triggers
branch
from
39b9bf0 to
b6977e6
Compare
elsmr
approved these changes
Jul 9, 2024
|
✅ All Cypress E2E specs passed |
ShireenMissi
approved these changes
Jul 9, 2024
|
✅ All Cypress E2E specs passed |
This was referenced Jul 10, 2024
Merged
Merged
Merged
Merged
|
Got released with |
jeanpaul
pushed a commit
that referenced
this pull request
Jul 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
When a trigger node is being tested, the node returns a
closeFunctionmethod to do all the cleanup after the node has been triggered by an external message. However if the user stops the node before it has been triggered,closeFunctionwas not being called, leaving behind dangling connections and consumers, which could lead to these dangling consumers picking up messages, but not being able to process them correctly.This PR changes
Workflow.runNodeto automatically callcloseFunctionwhen the trigger execution is aborted.Related Linear tickets, Github issues, and Community forum posts
#8871
NODE-1230
Review / Merge checklist