feat(Google Cloud Firestore Node): Add support for service account and document creation with id #9713
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
adrian-martinez-onestic
changed the title
n8n-assistant
bot
added
community
This was referenced Jun 12, 2024
Joffcom
changed the title
Joffcom
previously approved these changes
Jul 1, 2024
|
Since maintainers aren't allowed to edit this PR, I'm unable to fix the CI issues. When creating any future PRs, please make sure that this checkbox is checked |
adrian-martinez-onestic
force-pushed
the
feature/firestore-SA-document-create-with-id
branch
from
429d248 to
5d86664
Compare
|
Cherry-picked commit with CI fixes, also updated branch with latest master changes |
netroy
approved these changes
Jul 8, 2024
adrian-martinez-onestic
deleted the
feature/firestore-SA-document-create-with-id
branch
This was referenced Jul 10, 2024
Merged
Merged
Merged
Merged
|
Got released with |
jeanpaul
pushed a commit
that referenced
this pull request
Jul 11, 2024
…d document creation with id (#9713) Co-authored-by: कारतोफ्फेलस्क्रिप्ट™ <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds two features:
Details
While its possible to use Firestore using a service account, it is currently not supported by n8n, as noted at https://docs.n8n.io/integrations/builtin/credentials/google/#compatible-nodes. Allowing to use a service account in this node allows not depending on a personal account, and provides a reliable way to connect to Firestore.
In this way, proposed changes are backwards compatible, and offer the possibility of using either Oauth2 or Service Account authentication, and optionally, supply a document id, as it is possible while calling API or creating the document manually through the UI: