feat(editor): Chat Trigger tweaks #9618
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Oleg Ivaniv <[email protected]>
Signed-off-by: Oleg Ivaniv <[email protected]>
Signed-off-by: Oleg Ivaniv <[email protected]>
Signed-off-by: Oleg Ivaniv <[email protected]>
Signed-off-by: Oleg Ivaniv <[email protected]>
n8n-assistant
bot
added
core
michael-radency
previously approved these changes
Jun 4, 2024
| @@ -118,7 +118,7 @@ export abstract class DirectoryLoader { | |||
|
|
|||
| if (currentVersionNode.hasOwnProperty('executeSingle')) { | |||
| throw new ApplicationError( | |||
| '"executeSingle" has been removed. Please update the code of this node to use "execute" instead!', | |||
| '"executeSingle" has been removed. Please update the code of this node to use "execute" instead.', | |||
There was a problem hiding this comment.
We have a rule n8n-nodes-base/node-param-description-excess-final-period for not adding a final period in single-sentence node descriptions. Maybe we should apply this rule to those errors as well.
There was a problem hiding this comment.
It's a good point, I've asked David if we should keep the final period or not. Thanks!
There was a problem hiding this comment.
As per David's request, I've removed the final period for single-sentence errors. Could you re-approve, please?
2 flaky tests on run #5305 ↗︎
Details:
|
||||||||||||||||||||||||
| Test | Artifacts | |
|---|---|---|
| NDV > should not retrieve remote options when required params throw errors |
Screenshots
Video
|
|
| NDV > Stop listening for trigger event from NDV |
Screenshots
Video
|
|
Review all test suite changes for PR #9618 ↗︎
|
✅ All Cypress E2E specs passed |
Signed-off-by: Oleg Ivaniv <[email protected]>
OlegIvaniv
force-pushed
the
ai-179-chat-trigger-tweaks-and-other-tiny-ones
branch
from
cd02994 to
8eccf59
Compare
michael-radency
approved these changes
Jun 4, 2024
1 flaky test on run #5307 ↗︎
Details:
|
|||||||||||||||||||||
| Test | Artifacts | |
|---|---|---|
| NDV > should not retrieve remote options when required params throw errors |
Screenshots
Video
|
|
Review all test suite changes for PR #9618 ↗︎
|
✅ All Cypress E2E specs passed |
1 flaky test on run #5312 ↗︎
Details:
|
|||||||||||||||||||||
| Test | Artifacts | |
|---|---|---|
| NDV > should not retrieve remote options when required params throw errors |
Screenshots
Video
|
|
Review all test suite changes for PR #9618 ↗︎
Merged
|
Got released with |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Related tickets and issues
Review / Merge checklist
(no-changelog)otherwise. (conventions)