Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(editor): Node Creator AI nodes improvements #9484

Merged
merged 26 commits into from
May 30, 2024
Merged

feat(editor): Node Creator AI nodes improvements #9484

merged 26 commits into from
May 30, 2024

Conversation

OlegIvaniv
Copy link
Contributor

@OlegIvaniv OlegIvaniv commented May 22, 2024 •
edited
Loading

Summary

This PR implements several AI-nodes-related UX/UI improvements to the Node Creator panel.

  • Add a new NodeCreator type — link, use it to add a link to AI templates in the root AI view
  • Refresh styling of badges, allow color customization
  • Add "borderless" style to the ViewItem and apply it to the AI view item
  • Modify nodes search logic:
    • Hide non-root nodes from global search if there isn't a root node on the canvas
    • Split the search AI matches into sections based on their node subcategory
  • Add Posthog experiment to auto-add manual trigger new when creating a new workflow
CleanShot.2024-05-22.at.11.25.37.mp4

Related tickets and issues

Include links to Linear ticket or Github issue or Community forum post. Important in order to close automatically and provide context to reviewers.

Review / Merge checklist

  • PR title and summary are descriptive. Remember, the title automatically goes into the changelog. Use (no-changelog) otherwise. (conventions)
  • Docs updated or follow-up ticket created.
  • Tests included.

    A bug is not considered fixed, unless a test is added to prevent it from happening again.
    A feature is not complete without tests.

OlegIvaniv added 10 commits May 16, 2024 16:45
@OlegIvaniv
WIP: Add support for DynamicStructuredTool
a8fca31
@OlegIvaniv
Add option to use example JSON object to generate schema
f8247c4
@OlegIvaniv
Merge branch 'master' into feat/custom-tool-schema
040ae5f
@OlegIvaniv
Wrap the schema generation as util, refactor Structured Output Parser…
bdf6c66 
… to use it

Signed-off-by: Oleg Ivaniv <[email protected]>
@OlegIvaniv
Revert editor changes
22659d5 
Signed-off-by: Oleg Ivaniv <[email protected]>
@OlegIvaniv
Fix pnpm-lock
a7f1216 
Signed-off-by: Oleg Ivaniv <[email protected]>
@OlegIvaniv
Remove old editor files
b299c44 
Signed-off-by: Oleg Ivaniv <[email protected]>
@OlegIvaniv
Add template role override
e9e3d2c 
Signed-off-by: Oleg Ivaniv <[email protected]>
@OlegIvaniv
feat(editor): Node Creator AI nodes improvements
2dfd3c3 
Signed-off-by: Oleg Ivaniv <[email protected]>
@OlegIvaniv
Remove unused code
c8bb0a0 
Signed-off-by: Oleg Ivaniv <[email protected]>
@n8n-assistant n8n-assistant bot added n8n team Authored by the n8n team ui Enhancement in /editor-ui or /design-system labels May 22, 2024
@cypress Cypress
Copy link

cypress bot commented May 22, 2024 •
edited
Loading

4 flaky tests on run #5185 ↗︎

0 361 0 0 Flakiness 4

Details:

🌳 🖥️ browsers:node18.12.0-chrome107 🤖 OlegIvaniv 🗃️ e2e/*
Project: n8n Commit: d823cad6f0
Status: Passed Duration: 05:09 💡
Started: May 30, 2024 2:30 PM Ended: May 30, 2024 2:35 PM
Flakiness  5-ndv.cy.ts • 2 flaky tests

View Output Video

Test Artifacts
NDV > should not retrieve remote options when required params throw errors Screenshots Video
NDV > Stop listening for trigger event from NDV Screenshots Video
Flakiness  20-workflow-executions.cy.ts • 1 flaky test

View Output Video

Test Artifacts
Current Workflow Executions > should auto load more items if there is space and auto scroll Test Replay Screenshots Video
Flakiness  24-ndv-paired-item.cy.ts • 1 flaky test

View Output Video

Test Artifacts
NDV > resolves expression with default item when input node is not parent, while still pairing items Test Replay Screenshots Video

Review all test suite changes for PR #9484 ↗︎

Base automatically changed from feat/custom-tool-schema to master May 22, 2024 12:29
@OlegIvaniv OlegIvaniv marked this pull request as ready for review May 27, 2024 14:54
@OlegIvaniv OlegIvaniv force-pushed the feat/ai-180-nodes-panel-improvements-for-ai branch from b0a9e06 to 0039745 Compare May 29, 2024 10:11
elsmr
elsmr reviewed May 29, 2024
View reviewed changes
Copy link
Member

@elsmr elsmr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works great 👍 left some small code comments

@OlegIvaniv
Copy link
Contributor Author

@elsmr Thanks for the review! I've addressed your feedback; could you have another look, please? 🙏

@OlegIvaniv OlegIvaniv requested a review from elsmr May 30, 2024 13:42
elsmr
elsmr approved these changes May 30, 2024
View reviewed changes
Copy link
Member

@elsmr elsmr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@OlegIvaniv OlegIvaniv merged commit be4f54d into master May 30, 2024
50 checks passed
@OlegIvaniv OlegIvaniv deleted the feat/ai-180-nodes-panel-improvements-for-ai branch May 30, 2024 14:53
MiloradFilipovic added a commit that referenced this pull request May 31, 2024
@MiloradFilipovic
Merge branch 'master' into ADO-2220-agent-assistant-poc
a29596b 
* master:
  fix(editor): Fix ts errors across the board (no-changelog) (#9561)
  refactor(core): Extract all Auth-related User columns into a separate entity (#9557)
  refactor(core): Update supertest, and fix some typing errors (no-changelog) (#9527)
  fix(editor): Render checkboxes in markdown (#9549)
  test(core): Rename and combine all credential api tests (no-changelog) (#9550)
  🚀 Release 1.44.0 (#9553)
  feat(editor): Node Creator AI nodes improvements  (#9484)
  fix(editor): Show workflow data in header when execution page is hard reloaded (#9529)
  refactor(core): Stop reporting to Sentry `NodeApiError` with 5xx status codes (no-changelog) (#9552)
  feat: HighLevel oauth2 api credentials (#9542)
  fix(editor): Fix empty node name handling (#9548)
  ci: Fix vulnerable dev dependencies (no-changelog) (#9545)
  fix: Don't throw errors for NaN in number operators in the filter component  (#9506)
  fix(core): Try setting postgres search_path on the database (#9530)
  fix(editor): Redirect to workflows list after deleting a workflow (#9546)

# Conflicts:
#	packages/editor-ui/src/views/NodeView.vue
#	pnpm-lock.yaml
@github-actions github-actions bot mentioned this pull request Jun 5, 2024
Merged
@janober
Copy link
Member

janober commented Jun 5, 2024

Got released with [email protected]

@OlegIvaniv OlegIvaniv mentioned this pull request Jul 12, 2024
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@elsmr elsmr elsmr approved these changes

Assignees
No one assigned
Labels
n8n team Authored by the n8n team Released ui Enhancement in /editor-ui or /design-system
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@OlegIvaniv @janober @elsmr