feat(editor): Add pagination to the workflows list #13100
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Adding `paginated-list` mode to the `ResourcesListLayout`component - Implemented paging in workflows store
MiloradFilipovic
changed the title
n8n-assistant
bot
added
n8n team
MiloradFilipovic
force-pushed
the
ADO-3153-workflow-list-pagination
branch
from
7844693 to
b3a84df
Compare
⚡️ Using wf activator return value in the workflow card
MiloradFilipovic
force-pushed
the
ADO-3153-workflow-list-pagination
branch
from
b3a84df to
73ee4f9
Compare
r00gm
reviewed
Feb 12, 2025
packages/editor-ui/src/components/forms/ResourceFiltersDropdown.vue
Outdated
Show resolved
Hide resolved
r00gm
reviewed
Feb 12, 2025
packages/editor-ui/src/components/layouts/ResourcesListLayout.vue
Outdated
Show resolved
Hide resolved
r00gm
previously approved these changes
Feb 13, 2025
There was a problem hiding this comment.
@MiloradFilipovic some minor comments.
Tested the branch and it seems to be working correctly
n8n
|
||||||||||||||||||||||||||||||||||||||||
| Project |
n8n
|
| Branch Review |
ADO-3153-workflow-list-pagination
|
| Run status |
|
| Run duration | 05m 01s |
| Commit |
|
| Committer | Milorad FIlipović |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
Failures
|
1
|
Flaky
|
1
|
Pending
|
5
|
Skipped
|
0
|
Passing
|
435
|
| View all changes introduced in this branch ↗︎ | |
Tests for review
e2e/23-variables.cy.ts • 1 failed test
| Test | Artifacts | |
|---|---|---|
| Variables > licensed > should search for a variable |
Test Replay
Screenshots
Video
|
|
e2e/12-canvas.cy.ts • 1 flaky test
| Test | Artifacts | |
|---|---|---|
| Canvas Node Manipulation and Navigation > should preserve connections after rename & node-view switch |
Screenshots
Video
|
|
|
✅ All Cypress E2E specs passed |
r00gm
previously approved these changes
Feb 13, 2025
|
|
r00gm
approved these changes
Feb 14, 2025
|
✅ All Cypress E2E specs passed |
Merged
|
Got released with |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Implementing pagination in the workflows list. In order to achieve this, we are introducing the following changes:
ResourcesListLayoutcomponent:list-paginated, which renders list of Items with pagination controlslistmode tolist-fullIResource-->ResourceIFiltersto type and renamed -->BaseFiltersWorkflowsViewcomponent:ResourcesListLayoutWorkflowCardcomponent now emits events related to workflow action so they can be communicated up to theWorkflowsViewcountanddataas served by our rest endpointsScreenshot
Related Linear tickets, Github issues, and Community forum posts
Closes ADO-3153
Review / Merge checklist
release/backport(if the PR is an urgent fix that needs to be backported)