Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhance(rate-limit): dependency cleanup #2443

Merged
merged 2 commits into from
Feb 20, 2025
Merged

enhance(rate-limit): dependency cleanup #2443

merged 2 commits into from
Feb 20, 2025

Conversation

ardatan
Copy link
Collaborator

@ardatan ardatan commented Feb 20, 2025

Move the code from graphql-rate-limiter to the plugin to get rid of old, unused dependencies like old version of graphql-tools and unused graphql-middleware etc.

Related ardatan/whatwg-node#2077

Copy link

changeset-bot bot commented Feb 20, 2025

🦋 Changeset detected

Latest commit: d2fff83

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@envelop/rate-limiter Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

🚀 Snapshot Release (alpha)

The latest changes of this PR are available as alpha on npm (based on the declared changesets):

Package Version Info
@envelop/rate-limiter 7.0.1-alpha-20250220123804-d2fff83f69d0c1f19c65b6e4a0b3421fbe9d8516 npm ↗︎ unpkg ↗︎

@ardatan ardatan merged commit 75ae40e into main Feb 20, 2025
15 checks passed
@theguild-bot
Copy link
Collaborator

✅ Benchmark Results

     ✓ no_errors
     ✓ expected_result

     checks.............................................: 100.00% ✓ 927028      ✗ 0     
     ✓ { mode:envelop-cache-and-no-internal-tracing }...: 100.00% ✓ 217016      ✗ 0     
     ✓ { mode:envelop-cache-jit }.......................: 100.00% ✓ 363144      ✗ 0     
     ✓ { mode:envelop-just-cache }......................: 100.00% ✓ 215820      ✗ 0     
     ✓ { mode:graphql-js }..............................: 100.00% ✓ 131048      ✗ 0     
     data_received......................................: 3.5 GB  30 MB/s
     data_sent..........................................: 202 MB  1.7 MB/s
     envelop_init.......................................: avg=0s      min=0s       med=0s      max=0s       p(90)=0s      p(95)=0s     
     ✓ { mode:envelop-cache-jit }.......................: avg=0s      min=0s       med=0s      max=0s       p(90)=0s      p(95)=0s     
     ✓ { mode:envelop-just-cache }......................: avg=0s      min=0s       med=0s      max=0s       p(90)=0s      p(95)=0s     
     ✓ { mode:graphql-js }..............................: avg=0s      min=0s       med=0s      max=0s       p(90)=0s      p(95)=0s     
     envelop_total......................................: avg=0s      min=0s       med=0s      max=0s       p(90)=0s      p(95)=0s     
     ✓ { mode:envelop-cache-jit }.......................: avg=0s      min=0s       med=0s      max=0s       p(90)=0s      p(95)=0s     
     ✓ { mode:envelop-just-cache }......................: avg=0s      min=0s       med=0s      max=0s       p(90)=0s      p(95)=0s     
     ✓ { mode:graphql-js }..............................: avg=0s      min=0s       med=0s      max=0s       p(90)=0s      p(95)=0s     
     event_loop_lag.....................................: avg=0s      min=0s       med=0s      max=0s       p(90)=0s      p(95)=0s     
     ✓ { mode:envelop-cache-and-no-internal-tracing }...: avg=0s      min=0s       med=0s      max=0s       p(90)=0s      p(95)=0s     
     ✓ { mode:envelop-cache-jit }.......................: avg=0s      min=0s       med=0s      max=0s       p(90)=0s      p(95)=0s     
     ✓ { mode:envelop-just-cache }......................: avg=0s      min=0s       med=0s      max=0s       p(90)=0s      p(95)=0s     
     ✓ { mode:graphql-js }..............................: avg=0s      min=0s       med=0s      max=0s       p(90)=0s      p(95)=0s     
     graphql_context....................................: avg=0s      min=0s       med=0s      max=0s       p(90)=0s      p(95)=0s     
     ✓ { mode:envelop-cache-jit }.......................: avg=0s      min=0s       med=0s      max=0s       p(90)=0s      p(95)=0s     
     ✓ { mode:envelop-just-cache }......................: avg=0s      min=0s       med=0s      max=0s       p(90)=0s      p(95)=0s     
     ✓ { mode:graphql-js }..............................: avg=0s      min=0s       med=0s      max=0s       p(90)=0s      p(95)=0s     
     graphql_execute....................................: avg=0s      min=0s       med=0s      max=0s       p(90)=0s      p(95)=0s     
     ✓ { mode:envelop-cache-jit }.......................: avg=0s      min=0s       med=0s      max=0s       p(90)=0s      p(95)=0s     
     ✓ { mode:envelop-just-cache }......................: avg=0s      min=0s       med=0s      max=0s       p(90)=0s      p(95)=0s     
     ✓ { mode:graphql-js }..............................: avg=0s      min=0s       med=0s      max=0s       p(90)=0s      p(95)=0s     
     graphql_parse......................................: avg=0s      min=0s       med=0s      max=0s       p(90)=0s      p(95)=0s     
     ✓ { mode:envelop-cache-jit }.......................: avg=0s      min=0s       med=0s      max=0s       p(90)=0s      p(95)=0s     
     ✓ { mode:envelop-just-cache }......................: avg=0s      min=0s       med=0s      max=0s       p(90)=0s      p(95)=0s     
     ✓ { mode:graphql-js }..............................: avg=0s      min=0s       med=0s      max=0s       p(90)=0s      p(95)=0s     
     graphql_validate...................................: avg=0s      min=0s       med=0s      max=0s       p(90)=0s      p(95)=0s     
     ✓ { mode:envelop-cache-jit }.......................: avg=0s      min=0s       med=0s      max=0s       p(90)=0s      p(95)=0s     
     ✓ { mode:envelop-just-cache }......................: avg=0s      min=0s       med=0s      max=0s       p(90)=0s      p(95)=0s     
     ✓ { mode:graphql-js }..............................: avg=0s      min=0s       med=0s      max=0s       p(90)=0s      p(95)=0s     
     http_req_blocked...................................: avg=2.91µs  min=1.17µs   med=2.59µs  max=3.35ms   p(90)=3.45µs  p(95)=3.84µs 
     http_req_connecting................................: avg=15ns    min=0s       med=0s      max=682.51µs p(90)=0s      p(95)=0s     
     http_req_duration..................................: avg=2.28ms  min=153.93µs med=2.05ms  max=75.94ms  p(90)=4.1ms   p(95)=4.68ms 
       { expected_response:true }.......................: avg=2.28ms  min=153.93µs med=2.05ms  max=75.94ms  p(90)=4.1ms   p(95)=4.68ms 
     ✓ { mode:envelop-cache-and-no-internal-tracing }...: avg=2.47ms  min=375.59µs med=2.21ms  max=17.63ms  p(90)=4.33ms  p(95)=4.71ms 
     ✓ { mode:envelop-cache-jit }.......................: avg=1.33ms  min=153.93µs med=1.09ms  max=15.06ms  p(90)=2.18ms  p(95)=2.33ms 
     ✓ { mode:envelop-just-cache }......................: avg=2.47ms  min=330.74µs med=2.2ms   max=36.38ms  p(90)=4.31ms  p(95)=4.7ms  
     ✓ { mode:graphql-js }..............................: avg=4.29ms  min=623.57µs med=3.74ms  max=75.94ms  p(90)=7.21ms  p(95)=7.8ms  
     http_req_failed....................................: 0.00%   ✓ 0           ✗ 463514
     http_req_receiving.................................: avg=33.44µs min=11.54µs  med=28.63µs max=7ms      p(90)=44.99µs p(95)=49.99µs
     http_req_sending...................................: avg=12.31µs min=3.94µs   med=9.64µs  max=10.91ms  p(90)=14.49µs p(95)=18.54µs
     http_req_tls_handshaking...........................: avg=0s      min=0s       med=0s      max=0s       p(90)=0s      p(95)=0s     
     http_req_waiting...................................: avg=2.24ms  min=121.13µs med=2ms     max=75.84ms  p(90)=4.05ms  p(95)=4.63ms 
     http_reqs..........................................: 463514  3862.484773/s
     iteration_duration.................................: avg=2.58ms  min=352.3µs  med=2.32ms  max=76.42ms  p(90)=4.4ms   p(95)=4.99ms 
     iterations.........................................: 463514  3862.484773/s
     vus................................................: 10      min=10        max=10  
     vus_max............................................: 20      min=20        max=20  

Copy link
Contributor

💻 Website Preview

The latest changes are available as preview in: https://2180aa1f.envelop.pages.dev

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants