Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: error in subscription source -> onSubscribeError invocation #2164

Merged
merged 1 commit into from
Mar 8, 2024

Conversation

n1ru4l
Copy link
Owner

@n1ru4l n1ru4l commented Mar 8, 2024

🚨 IMPORTANT: Please do not create a Pull Request without creating an issue first.

Any change needs to be discussed before proceeding. Failure to do so may result in the rejection of
the pull request.

Description

Please include a summary of the change and which issue is fixed. Please also include relevant
motivation and context. List any dependencies that are required for this change.

Fixes # (issue)

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as
    expected)
  • This change requires a documentation update

Screenshots/Sandbox (if appropriate/relevant):

Adding links to sandbox or providing screenshots can help us understand more about this PR and take
action on it as appropriate

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can
reproduce. Please also list any relevant details for your test configuration

  • Test A
  • Test B

Test Environment:

  • OS:
  • @envelop/...:
  • NodeJS:

Checklist:

  • I have followed the
    CONTRIBUTING doc and the
    style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented on my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

Further comments

If this is a relatively large or complex change, kick off the discussion by explaining why you chose
the solution you did and what alternatives you considered, etc...

Copy link

changeset-bot bot commented Mar 8, 2024

⚠️ No Changeset found

Latest commit: 3b87cee

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Contributor

github-actions bot commented Mar 8, 2024

💻 Website Preview

The latest changes are available as preview in: https://65ed25a9.envelop.pages.dev

@theguild-bot
Copy link
Collaborator

✅ Benchmark Results

     ✓ no_errors
     ✓ expected_result

     checks.............................................: 100.00% ✓ 864618      ✗ 0     
     data_received......................................: 3.3 GB  28 MB/s
     data_sent..........................................: 188 MB  1.6 MB/s
     envelop_total......................................: avg=0s      min=0s       med=0s     max=0s       p(90)=0s      p(95)=0s     
     ✓ { mode:envelop-cache-jit }.......................: avg=0s      min=0s       med=0s     max=0s       p(90)=0s      p(95)=0s     
     ✓ { mode:envelop-just-cache }......................: avg=0s      min=0s       med=0s     max=0s       p(90)=0s      p(95)=0s     
     ✓ { mode:graphql-js }..............................: avg=0s      min=0s       med=0s     max=0s       p(90)=0s      p(95)=0s     
     event_loop_lag.....................................: avg=0s      min=0s       med=0s     max=0s       p(90)=0s      p(95)=0s     
     ✓ { mode:envelop-cache-and-no-internal-tracing }...: avg=0s      min=0s       med=0s     max=0s       p(90)=0s      p(95)=0s     
     ✓ { mode:envelop-cache-jit }.......................: avg=0s      min=0s       med=0s     max=0s       p(90)=0s      p(95)=0s     
     ✓ { mode:envelop-just-cache }......................: avg=0s      min=0s       med=0s     max=0s       p(90)=0s      p(95)=0s     
     ✓ { mode:graphql-js }..............................: avg=0s      min=0s       med=0s     max=0s       p(90)=0s      p(95)=0s     
     http_req_blocked...................................: avg=1.83µs  min=681ns    med=1.62µs max=9.19ms   p(90)=2.19µs  p(95)=2.45µs 
     http_req_connecting................................: avg=9ns     min=0s       med=0s     max=691.82µs p(90)=0s      p(95)=0s     
     http_req_duration..................................: avg=2.48ms  min=152.37µs med=2.12ms max=77.73ms  p(90)=4.5ms   p(95)=5.04ms 
       { expected_response:true }.......................: avg=2.48ms  min=152.37µs med=2.12ms max=77.73ms  p(90)=4.5ms   p(95)=5.04ms 
     ✓ { mode:envelop-cache-and-no-internal-tracing }...: avg=2.58ms  min=320.46µs med=2.24ms max=16.29ms  p(90)=4.45ms  p(95)=4.87ms 
     ✓ { mode:envelop-cache-jit }.......................: avg=1.48ms  min=152.37µs med=1.17ms max=15.47ms  p(90)=2.41ms  p(95)=2.59ms 
     ✓ { mode:envelop-just-cache }......................: avg=2.62ms  min=377.81µs med=2.26ms max=35.44ms  p(90)=4.49ms  p(95)=4.96ms 
     ✓ { mode:graphql-js }..............................: avg=5.01ms  min=592.7µs  med=4.24ms max=77.73ms  p(90)=8.45ms  p(95)=9.16ms 
     http_req_failed....................................: 0.00%   ✓ 0           ✗ 432309
     http_req_receiving.................................: avg=33.75µs min=11.76µs  med=26.5µs max=15.79ms  p(90)=41.1µs  p(95)=46µs   
     http_req_sending...................................: avg=12.07µs min=4.5µs    med=9.77µs max=13.96ms  p(90)=13.75µs p(95)=17.88µs
     http_req_tls_handshaking...........................: avg=0s      min=0s       med=0s     max=0s       p(90)=0s      p(95)=0s     
     http_req_waiting...................................: avg=2.44ms  min=125.85µs med=2.08ms max=77.61ms  p(90)=4.44ms  p(95)=4.98ms 
     http_reqs..........................................: 432309  3602.481601/s
     iteration_duration.................................: avg=2.77ms  min=355.86µs med=2.38ms max=78.25ms  p(90)=4.8ms   p(95)=5.39ms 
     iterations.........................................: 432309  3602.481601/s
     vus................................................: 4       min=4         max=10  
     vus_max............................................: 20      min=20        max=20  

@n1ru4l n1ru4l merged commit bc620fa into main Mar 8, 2024
17 checks passed
@n1ru4l n1ru4l deleted the test-on-subscribe-error branch March 8, 2024 10:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants