Fix many files bug #920
Merged
Fix many files bug #920
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Just use a long file name to stress
|
Fixes #915 |
flub
previously approved these changes
Apr 3, 2023
write_buf does not guarantee that the entire buffer is written.
rklaehn
force-pushed
the
fix-many-files-bug
branch
from
3b886fa to
fe0a4e3
Compare
flub
approved these changes
Apr 3, 2023
matheus23
pushed a commit
that referenced
this pull request
Nov 14, 2024
* test: make the many_files test fail for 10000 files Just use a long file name to stress * fix: make sure we write the entire collection write_buf does not guarantee that the entire buffer is written.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I made the test fail by making the file name really long.
Made the file name repeat the number multiple times so a radix tree does not optimize the long name away, just in case we do radix trees in the future.