-
Notifications
You must be signed in to change notification settings - Fork 213
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: use chunk groups feature #798
Conversation
caution: this is not compatible with existing iroh/sendme
what's missing here, given this is a draft? |
It was a draft because the crate was not published yet, and the tests were failing. Let's see, maybe they work now... |
/perf |
/netsim |
body: |
|
@rklaehn do we want to ship this? did you compare the perf numbers? |
Well, perf is basically identical, a tad faster. The main benefit is that the outboard is smaller, so we can share larger files with outboard in memory. As far as I am concerned it is ready to go - provided that we're clear that this might change in the future, together with the protocol. |
@flub any concerns merging this before DC release? |
i guess there's no problem with merging this? |
caution: this is not compatible with existing iroh/sendme
caution: this is not compatible with existing iroh/sendme