Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(portmapper): enforce timeouts for upnp #2877

Merged
merged 6 commits into from
Nov 1, 2024
Merged

fix(portmapper): enforce timeouts for upnp #2877

merged 6 commits into from
Nov 1, 2024

Conversation

dignifiedquire
Copy link
Contributor

@dignifiedquire dignifiedquire commented Nov 1, 2024 •
edited
Loading

Closes #2876

@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 1, 2024 •
edited
Loading

Documentation for this PR has been generated and is available at: https://n0-computer.github.io/iroh/pr/2877/docs/iroh/

Last updated: 2024-11-01T20:35:22Z

@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 1, 2024 •
edited
Loading

Netsim report & logs for this PR have been generated and is available at: LOGS
This report will remain available for 3 days.

Last updated for commit: 914bf0d

@dignifiedquire dignifiedquire changed the title [NOT MERGE] debug: simulate upnp issues and add iroh.toml config [WIP] fix(portmapper): enforce timeouts for upnp Nov 1, 2024
dignifiedquire
dignifiedquire commented Nov 1, 2024
View reviewed changes
@dignifiedquire dignifiedquire added this to the v0.28.0 milestone Nov 1, 2024
@dignifiedquire dignifiedquire changed the title [WIP] fix(portmapper): enforce timeouts for upnp fix(portmapper): enforce timeouts for upnp Nov 1, 2024
@dignifiedquire dignifiedquire marked this pull request as ready for review November 1, 2024 11:20
@matheus23 matheus23 mentioned this pull request Nov 1, 2024
Merged
4 tasks
@matheus23
Copy link
Member

What do you think of merging #2880 into this PR, then merging this? I think that's probably how we should do this.

@dignifiedquire
Copy link
Contributor Author

What do you think of merging #2880 into this PR, then merging this? I think that's probably how we should do this.

yes, please do

divagant-martian
divagant-martian approved these changes Nov 1, 2024
View reviewed changes
Copy link
Contributor

@divagant-martian divagant-martian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@divagant-martian divagant-martian added this pull request to the merge queue Nov 1, 2024
Merged via the queue into main with commit 00a3f88 Nov 1, 2024
26 of 27 checks passed
@dignifiedquire dignifiedquire deleted the debug-upnp branch November 1, 2024 22:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@divagant-martian divagant-martian divagant-martian approved these changes

Assignees
No one assigned
Labels
None yet
Projects
iroh
Archived in project
Milestone
v0.28.0
Development

Successfully merging this pull request may close these issues.

iroh does not work with relays without STUN on networks without UPnP
3 participants
@dignifiedquire @matheus23 @divagant-martian