Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(iroh-net): Log the crate version number #2746

Merged
merged 1 commit into from
Oct 4, 2024
Merged

feat(iroh-net): Log the crate version number #2746

merged 1 commit into from
Oct 4, 2024

Conversation

flub
Copy link
Contributor

@flub flub commented Sep 24, 2024

Description

This adds a DEBUG-level log logging the crate version number.

Breaking Changes

None

Notes & open questions

This is not the first log message appearing, the MagicSock and a few
other pieces already have been logging by this time. Also I'm not
particularly bound to this wording. Maybe there are other things that
should be added to this line?

Change checklist

  • Self-review.
  • [ ] Documentation updates following the style guide, if relevant.
  • [ ] Tests if relevant.
  • [ ] All breaking changes documented.

This adds a DEBUG-level log logging the crate version number.
@flub flub requested a review from dignifiedquire September 24, 2024 13:55
Copy link

Documentation for this PR has been generated and is available at: https://n0-computer.github.io/iroh/pr/2746/docs/iroh/

Last updated: 2024-09-24T13:54:59Z

@matheus23
Copy link
Member

Did you test whether the environment variable reports the version of the crate, even if it's a deep transitive dependency?
I.e. I'd like to avoid a case where it reports version "0.1.0", if you compile "my-crate v 0.1.0" which depends on "iroh-net v 0.26.0"

@flub
Copy link
Contributor Author

flub commented Sep 25, 2024

Did you test whether the environment variable reports the version of the crate, even if it's a deep transitive dependency? I.e. I'd like to avoid a case where it reports version "0.1.0", if you compile "my-crate v 0.1.0" which depends on "iroh-net v 0.26.0"

Pretty sure that's fine: https://doc.rust-lang.org/cargo/reference/environment-variables.html

@flub flub added this pull request to the merge queue Oct 4, 2024
Merged via the queue into main with commit 12f74e2 Oct 4, 2024
27 checks passed
@flub flub deleted the flub/log-version branch October 4, 2024 08:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants