feat(iroh-net): allow customizing republish delay for the pkarr publisher #2637
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
set republish delay to zero in test resize testnet to 2 nodes (minimum)
|
Documentation for this PR has been generated and is available at: https://n0-computer.github.io/iroh/pr/2637/docs/iroh/ Last updated: 2024-08-19T11:40:24Z |
|
Oh how ironic that (potentially) fixing a flake is blocked by another test being flaky 🙃 |
|
@rklaehn is this ready? |
dignifiedquire
changed the title
dignifiedquire
approved these changes
Aug 19, 2024
matheus23
pushed a commit
that referenced
this pull request
Nov 14, 2024
…sher (#2637) ## Description The pkarr dht publisher has two delays, the initial delay and the republish delay. These were constants so far, but now are configurable in the builder. This allows us to set the delay to 0s in the dht_discovery_smoke test. ## Breaking Changes None ## Notes & open questions Will this fix the flakiness? ## Change checklist - [x] Self-review. - [x] Documentation updates following the [style guide](https://rust-lang.github.io/rfcs/1574-more-api-documentation-conventions.html#appendix-a-full-conventions-text), if relevant. - [ ] Tests if relevant. - [x] All breaking changes documented. Co-authored-by: Friedel Ziegelmayer <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The pkarr dht publisher has two delays, the initial delay and the republish delay. These were constants so far, but now are configurable in the builder.
This allows us to set the delay to 0s in the dht_discovery_smoke test.
Breaking Changes
None
Notes & open questions
Will this fix the flakiness?
Change checklist