Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(iroh-cli): Improve bao_store_migration test logging #2483

Merged
merged 3 commits into from
Jul 16, 2024

Conversation

matheus23
Copy link
Member

@matheus23 matheus23 commented Jul 9, 2024

Description

We didn't get good logs on the cli_bao_store_migration test so far. Here's what it's output was in a failure case:

--- STDOUT:              iroh-cli::cli cli_bao_store_migration ---

running 1 test
|Iroh is running
|Node ID: cnzuojj4sbo2ulpqoo2riyrdsn2j4pnp3b5bgrjubsft72nutlca
iroh started up.
test cli_bao_store_migration ... FAILED

failures:

failures:
    cli_bao_store_migration

test result: FAILED. 0 passed; 1 failed; 0 ignored; 0 measured; 12 filtered out; finished in 2.71s


--- STDERR:              iroh-cli::cli cli_bao_store_migration ---
thread 'cli_bao_store_migration' panicked at iroh-cli/tests/cli.rs:394:5:
assertion `left == right` failed
  left: ""
 right: "4yny3v7anmzzsajv2amm3nxpqd2owfw4dqnjwq6anv7nj2djmt2q (0 B)\n"

This was only capturing stdout from one of the four iroh commands.

This PR changes that. Now stdout and stderr are captured by all iroh commands in the cli_bao_store_migration test.

Breaking Changes

None

Notes & open questions

I've also switched PathBuf::to_string_lossy() calls to be PathBuf::display() calls.

Change checklist

  • Self-review.
  • [ ] Documentation updates following the style guide, if relevant.
  • [ ] Tests if relevant.
  • [ ] All breaking changes documented.

@matheus23 matheus23 self-assigned this Jul 9, 2024
@ramfox ramfox added this to the v0.21.0 milestone Jul 10, 2024
@dignifiedquire dignifiedquire added this pull request to the merge queue Jul 16, 2024
Merged via the queue into main with commit d17ffa3 Jul 16, 2024
27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants