fix(iroh-docs): ensure docs db write txn gets closed regularly under all circumstances #2474
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
basically duplicate the logic from fn tables() to fn modify() to make sure that we commit after a short time even if we only do modify calls and no read calls.
With this we got 3 mechanisms to force a transaction to close: - the timeout check in tables() if you only read but have a write txn - the timeout check in modify() if you only write - the timer in the actor if you don't do anything at all
github-merge-queue
bot
removed this pull request from the merge queue due to no response for status checks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The docs db uses batching to reduce the number of write transactions. Before this, under certain circumstances (lots of activity, exclusively writes) the transaction would remain open for a long time.
This adds logic to modify to make sure that transactions will be committed when they get too old in any case.
Breaking Changes
None
Notes & open questions
Change checklist
Documentation updates following the style guide, if relevant.Tests if relevant.All breaking changes documented.