Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Audit select! usage for flume channel sends #2415

Closed
rklaehn opened this issue Jun 26, 2024 · 1 comment
Closed

Audit select! usage for flume channel sends #2415

rklaehn opened this issue Jun 26, 2024 · 1 comment
Labels
_c-iroh-legacy Formerly big iroh node with all protocols

Comments

@rklaehn
Copy link
Contributor

rklaehn commented Jun 26, 2024

Sending into a flume channel is not cancel-safe. We use select! in our "actors" a lot.

Here is a discussion about flume cancel safety. It seems that while recv_async is cancel-safe, send_async is not, in a subtle way. We should look for places where we send from a select! statement and see if they could be affected.

zesterer/flume#104

@rklaehn rklaehn added the _c-iroh-legacy Formerly big iroh node with all protocols label Jun 26, 2024
@ramfox ramfox moved this to 📋 Backlog in iroh Jul 10, 2024
@rklaehn
Copy link
Contributor Author

rklaehn commented Aug 14, 2024

We are now trying to avoid flume channels wherever possible because of cancel safety issues in both send and recv.

@rklaehn rklaehn closed this as completed Aug 14, 2024
@github-project-automation github-project-automation bot moved this from 📋 Backlog to ✅ Done in iroh Aug 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
_c-iroh-legacy Formerly big iroh node with all protocols
Projects
Archived in project
Development

No branches or pull requests

1 participant