refactor(iroh): move code from builder to node and make things nicer #2386
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Frando
force-pushed
the
refactor/node-and-builder
branch
from
e36e948 to
32ef8ac
Compare
Frando
force-pushed
the
refactor/node-and-builder
branch
from
1d65c7b to
ec042bb
Compare
dignifiedquire
approved these changes
Jun 19, 2024
|
Very much in favour of moving core node logic into node. It always felt weird to have half the logic in the builder! |
rklaehn
approved these changes
Jun 19, 2024
rklaehn
reviewed
Jun 19, 2024
| handler.inner.sync.doc_start_sync(req).await | ||
| }) | ||
| let handler = Self::new(inner); | ||
| join_set.spawn(async move { |
There was a problem hiding this comment.
We are adding lots of tasks to the joinset. Presumably this is so they can all be properly shut down on shutdown.
But is it OK to add lots of tasks without ever calling join_next? won't you aggregate a lot of handles to long-finished short lived tasks?
There was a problem hiding this comment.
We do call join_next in the main loop, and break the main loop if a task panics - which is the main reason for the join set IMO (shutdown as well, but it won't matter much in practice because the tasks will also abort once the join set is dropped).
ppodolsky
pushed a commit
to izihawa/iroh
that referenced
this pull request
Jun 22, 2024
…0-computer#2386) This is a cleanup of the node and builder code. * Move `run` and `gc_loop` from `builder.rs` to `node.rs` - it is not about building but about running. * Improve the code flow and naming all around the builder, spawn and run functions * Make sure we shutdown the node correctly while spawning * Removed `Node::controller`. Use `Node::client` instead. The former was mostly unusable anyway because we made the RPC structs private. <!-- Any notes, remarks or open questions you have to make about the PR. --> - [x] Self-review. - [x] Documentation updates if relevant. - [ ] ~~Tests if relevant.~~ - [x] All breaking changes documented.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This is a cleanup of the node and builder code.
runandgc_loopfrombuilder.rstonode.rs- it is not about building but about running.Breaking Changes
Node::controller. UseNode::clientinstead. The former was mostly unusable anyway because we made the RPC structs private.Notes & open questions
Change checklist
Tests if relevant.