fix: Remove dead code detected by the rust beta compiler #2121
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The beta compiler identifies these as dead code.
flub
commented
Mar 25, 2024
iroh-sync/src/ranger.rs
Outdated
| // /// Returns true if `other` is a prefix of `self`. | ||
| // fn is_prefixed_by(&self, other: &Self) -> bool { | ||
| // other.is_prefix_of(self) | ||
| // } |
flub
changed the title
Frando
reviewed
Mar 25, 2024
|
@Frando could you, err, approve in that case? |
rklaehn
approved these changes
Mar 25, 2024
| @@ -216,43 +216,6 @@ impl<W: BaoBatchWriter, F: Fn(u64, usize) -> io::Result<()> + 'static> BaoBatchW | |||
| } | |||
| } | |||
|
|
|||
| /// A combined batch writer | |||
There was a problem hiding this comment.
Yeah, this is dead since we have a proper batch writer. In some branch I removed this already.
Frando
approved these changes
Mar 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The beta compiler identifies these as dead code.
Notes & open questions
Change checklist