feat: split CLI implementation into a new iroh-cli crate #2076
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dignifiedquire
force-pushed
the
feat-cli-crate
branch
from
e297bac to
3cd50aa
Compare
flub
approved these changes
Mar 13, 2024
| @@ -136,7 +136,7 @@ jobs: | |||
|
|
|||
| - name: Check MSRV all features | |||
| run: | | |||
| cargo +$MSRV check --workspace --all-targets --features cli | |||
| cargo +$MSRV check --workspace --all-targets | |||
There was a problem hiding this comment.
The name does not really match what it does. I don't know which one it should be though? Maybe it should be --all-features?
dignifiedquire
commented
Mar 13, 2024
matheus23
pushed a commit
that referenced
this pull request
Nov 14, 2024
Isolates the CLI implementation to its own crate. --------- Co-authored-by: Floris Bruynooghe <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Isolates the CLI implementation to its own crate.