Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs(derper): display the correct port number in the derper --dev help message #2048

Merged
merged 2 commits into from
Feb 28, 2024
Merged

docs(derper): display the correct port number in the derper --dev help message #2048

merged 2 commits into from
Feb 28, 2024

Conversation

ramfox
Copy link
Contributor

@ramfox ramfox commented Feb 28, 2024 •
edited
Loading

Description

Changed the derper --dev --help text to report port 3340.

Change checklist

  • Self-review.

@ramfox ramfox added the docs Improvements or additions to documentation label Feb 28, 2024
@ramfox ramfox self-assigned this Feb 28, 2024
@ramfox ramfox marked this pull request as ready for review February 28, 2024 20:13
@b5
Copy link
Member

b5 commented Feb 28, 2024

add docs: in front of your commit 😄

divagant-martian
divagant-martian requested changes Feb 28, 2024
View reviewed changes
Copy link
Contributor

@divagant-martian divagant-martian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

an iroh_dir was added here

@ramfox
Copy link
Contributor Author

ramfox commented Feb 28, 2024

add docs: in front of your commit 😄

ah the error is from the PR description being null, we squash merge so the commits all go away anyway

@divagant-martian divagant-martian added this pull request to the merge queue Feb 28, 2024
Merged via the queue into main with commit e1c9fda Feb 28, 2024
21 of 22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@divagant-martian divagant-martian divagant-martian approved these changes

Assignees

@ramfox ramfox

Labels
docs Improvements or additions to documentation
Projects
iroh
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ramfox @b5 @divagant-martian