chore(ci): Warn in our discord channel on failure #2044
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is better than error, since flaky tests really are expected to be flaky. And we don't want to miss other errors in that channel which are more important.
dignifiedquire
approved these changes
Feb 27, 2024
fubuloubu
pushed a commit
to ApeWorX/iroh
that referenced
this pull request
Feb 27, 2024
## Description This is better than error, since flaky tests really are expected to be flaky. And we don't want to miss other errors in that channel which are more important. ## Notes & open questions Maybe warn is even a bit high, but all that matters is that we get different colours in our channel. If later we send more notifications to that channel we can tweak the levels appropriately. ## Change checklist - [x] Self-review.
matheus23
pushed a commit
that referenced
this pull request
Nov 14, 2024
## Description This is better than error, since flaky tests really are expected to be flaky. And we don't want to miss other errors in that channel which are more important. ## Notes & open questions Maybe warn is even a bit high, but all that matters is that we get different colours in our channel. If later we send more notifications to that channel we can tweak the levels appropriately. ## Change checklist - [x] Self-review.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This is better than error, since flaky tests really are expected to be
flaky. And we don't want to miss other errors in that channel which
are more important.
Notes & open questions
Maybe warn is even a bit high, but all that matters is that we get
different colours in our channel. If later we send more notifications
to that channel we can tweak the levels appropriately.
Change checklist