fix(examples): Adjust and add examples #1968
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ramfox
force-pushed
the
adjust_examples
branch
from
0240e02 to
14c14c6
Compare
| } | ||
| } | ||
| drop(temp_pin); | ||
| progress.send(DownloadProgress::AllDone).await?; | ||
| anyhow::Ok(()) | ||
| let _ = progress.send(DownloadProgress::AllDone).await; | ||
| }); |
There was a problem hiding this comment.
we should also return the errors from the closure and check for errors here, currently this function will exit with Ok even though it failed
There was a problem hiding this comment.
I figured that we weren't awaiting the closure because the intended use case was to return once the download process was set up and expect users to listen for errors on the progress stream.
I refactored so that this was closer to the other methods that rely on progress streams for communciation.
Let me know if i'm missing something!
fubuloubu
pushed a commit
to ApeWorX/iroh
that referenced
this pull request
Feb 21, 2024
## Description Fixes incorrect information in our `iroh/examples` Also adds an example that shows the most basic way to use iroh to fetch content. related to n0-computer#1929 ## Notes & open questions Unfortunately, we don't seem to have very simple APIs for fetching (that isn't just exporting the content to an external path). Working through this. Also adds: - `BlobDownloadProgress` - this takes a stream of `DownloadProgress` and puts it into a form that will poll the stream by calling `finish` - adjusts the `blob_download0` function to not eat certain errors ## Change checklist - [x] Self-review. - [x] Documentation updates if relevant.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes incorrect information in our
iroh/examplesAlso adds an example that shows the most basic way to use iroh to fetch content.
related to #1929
Notes & open questions
Unfortunately, we don't seem to have very simple APIs for fetching (that isn't just exporting the content to an external path). Working through this.
Also adds:
BlobDownloadProgress- this takes a stream ofDownloadProgressand puts it into a form that will poll the stream by callingfinishblob_download0function to not eat certain errorsChange checklist