fix: allow some dead code for the nightly compiler #1934
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The nightly compiler (rightly I think) identifies the u64 as unread and suggests changing it with unit instead. This is the easy way out, not very nice. We also have a ProgressReader2 in iroh-bytes that's very similar. Maybe we should extract these and put them somewhere common.
flub
changed the title
Arqu
approved these changes
Jan 8, 2024
fubuloubu
pushed a commit
to ApeWorX/iroh
that referenced
this pull request
Feb 21, 2024
## Description The nightly compiler (rightly I think) identifies the u64 as unread and suggests changing it with unit instead. However the nightly compiler wrongly identifies some oneshot senders as dead code. Just get main working on CI again for now. ## Notes & open questions This is the easy way out, not very nice. We also have a ProgressReader2 in iroh-bytes that's very similar. Maybe we should extract these and put them somewhere common. ## Change checklist - [x] Self-review.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The nightly compiler (rightly I think) identifies the u64 as unread
and suggests changing it with unit instead.
However the nightly compiler wrongly identifies some oneshot senders
as dead code. Just get main working on CI again for now.
Notes & open questions
This is the easy way out, not very nice. We also have a
ProgressReader2 in iroh-bytes that's very similar. Maybe we should
extract these and put them somewhere common.
Change checklist