Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(iroh-sync): dl policies exists only if doc exists #1921

Merged

Conversation

divagant-martian
Copy link
Contributor

Description

Removes download policies when the replica is removed, and disallows adding download policies for documents not yet created

Notes & open questions

na

Change checklist

  • Self-review.
  • Documentation updates if relevant.
  • Tests if relevant.

Copy link
Contributor

@dignifiedquire dignifiedquire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe a test?

@dignifiedquire
Copy link
Contributor

@divagant-martian what's the status of this?

@dignifiedquire dignifiedquire added this pull request to the merge queue Jan 24, 2024
Merged via the queue into n0-computer:main with commit de7f603 Jan 24, 2024
18 checks passed
fubuloubu pushed a commit to ApeWorX/iroh that referenced this pull request Feb 21, 2024
## Description

Removes download policies when the replica is removed, and disallows
adding download policies for documents not yet created

## Notes & open questions

na

## Change checklist

- [x] Self-review.
- [ ] Documentation updates if relevant.
- [ ] Tests if relevant.

---------

Co-authored-by: Friedel Ziegelmayer <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants