refactor(logging): Reduce loglevel of blob GC #1866
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The blob GC was logging at info level, filling the info-level log with tons of repeated messages that are pretty useless. They probably all belong on debug, or maybe even below.
dignifiedquire
approved these changes
Dec 6, 2023
rklaehn
approved these changes
Dec 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The blob GC was logging at info level, filling the info-level log with
tons of repeated messages that are pretty useless. They probably all
belong on debug, or maybe even below.
Notes & open questions
Possibly some of these might be info if they carry something useful,
like showing a number that's not 0 or so. But as a first
approximation reducing everything to debug seems about right.
Change checklist
Documentation updates if relevant.Tests if relevant.