fix(derper): update config to auto generate keys #1599
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iroh-net/src/bin/derper.rs
Outdated
| .await | ||
| .context("unable to read config")?; | ||
| let config = toml::from_str(&config_ser).context("unable to decode config")?; | ||
| let mut secret_key_injected = false; | ||
| if !config_ser.contains("secret_key") { |
There was a problem hiding this comment.
I would strongly prefer to inject this after toml parsing, there is actually a nice way to do this.
#[serde(default = "SecretKey::generate")]
secret_key: SecretKey,will do exactly that.
There was a problem hiding this comment.
I swear serde is more powerful than any AI we have so far :D
| let config = toml::from_str(&config_ser).context("unable to decode config")?; | ||
| let config: Self = toml::from_str(&config_ser).context("unable to decode config")?; | ||
| if !config_ser.contains("secret_key") { | ||
| config.write_to_file(path).await?; |
There was a problem hiding this comment.
one last complain, lets add a log line for this event
dignifiedquire
approved these changes
Oct 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Deploying a derper node is a bit cumbersome right now if you don't run with default config. You have to provide a
secret_keybut have no easy path to generate one so either you dance to create a fresh config and then modify it or need to use some external thing to generate keys for you. Either way it's cumbersome.This just adds an extra handler to inject a secret key if not present already in the supplied config.
Notes & open questions
Change checklist