Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(iroh-net): use base32 encoding in the derper config for SecretKey #1385

Merged
merged 1 commit into from
Aug 21, 2023

Conversation

dignifiedquire
Copy link
Contributor

Description

This is not a nice config format 😅 secret_key = [100, 98, 53, 22, 194, 127, ... ]

Notes & open questions

Change checklist

  • Self-review.
  • Documentation updates if relevant.
  • Tests if relevant.

@dignifiedquire dignifiedquire requested review from flub and Arqu August 21, 2023 20:21
Copy link
Collaborator

@Arqu Arqu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔥

@dignifiedquire dignifiedquire added this pull request to the merge queue Aug 21, 2023
Merged via the queue into main with commit b8a1de8 Aug 21, 2023
@Arqu Arqu deleted the fix-derp-config-key-format branch August 21, 2023 21:26
matheus23 pushed a commit that referenced this pull request Nov 14, 2024
…#1385)

## Description

This is not a nice config format 😅 `secret_key = [100, 98, 53, 22, 194,
127, ... ]`


## Notes & open questions

## Change checklist

- [x] Self-review.
- [ ] Documentation updates if relevant.
- [x] Tests if relevant.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants