-
Notifications
You must be signed in to change notification settings - Fork 213
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix tls bugs & create an hp::derp::http::server::Server
#1077
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flub
reviewed
Jun 6, 2023
f77da77
to
85e3a67
Compare
flub
reviewed
Jun 9, 2023
flub
reviewed
Jun 9, 2023
flub
previously approved these changes
Jun 9, 2023
6 tasks
0083048
to
b597dfa
Compare
flub
previously approved these changes
Jun 13, 2023
34dff7d
to
33e2c52
Compare
33e2c52
to
aaa7979
Compare
Arqu
approved these changes
Jun 13, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🐰
Arqu
requested changes
Jun 13, 2023
Arqu
approved these changes
Jun 13, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🐰 🐰
matheus23
pushed a commit
that referenced
this pull request
Nov 14, 2024
Add TLS certificates & dialing via https in the derper and `hp::derp::http::client::Client`. Refactor to add a `hp::derp::http::server::Server` that optionally serves the derp code on HTTP or HTTPS depending on the configuration. Refactor the derper and any derp server tests to use the `hp::derp::http::server::Server`. Refactor DNS resolving to have one core resolver. Close the derp server and derper gracefully using `ctrl-c`. Adds more instrumentation to the derp server processes. Changes the default derp server hostname to `derp.iroh.network` --------- Co-authored-by: dignifiedquire <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The derper & our tests now use a
hp::derp::http::server::Server
as a Http(s) derp server.PR also fixes bugs in the tls connection.
closes #908