Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix tls bugs & create an hp::derp::http::server::Server #1077

Merged
merged 20 commits into from
Jun 13, 2023

Conversation

ramfox
Copy link
Contributor

@ramfox ramfox commented Jun 6, 2023

The derper & our tests now use a hp::derp::http::server::Server as a Http(s) derp server.

PR also fixes bugs in the tls connection.

closes #908

@ramfox ramfox self-assigned this Jun 6, 2023
@ramfox ramfox force-pushed the x-hp-derp-tls-debug branch from f77da77 to 85e3a67 Compare June 6, 2023 21:05
@ramfox ramfox marked this pull request as ready for review June 8, 2023 13:49
flub
flub previously approved these changes Jun 9, 2023
Base automatically changed from x-hp to main June 9, 2023 18:16
@dignifiedquire dignifiedquire dismissed flub’s stale review June 9, 2023 18:16

The base branch was changed.

@ramfox ramfox force-pushed the x-hp-derp-tls-debug branch from 0083048 to b597dfa Compare June 12, 2023 18:05
@ramfox ramfox requested review from flub and dignifiedquire June 12, 2023 21:39
flub
flub previously approved these changes Jun 13, 2023
@ramfox ramfox force-pushed the x-hp-derp-tls-debug branch from 34dff7d to 33e2c52 Compare June 13, 2023 17:31
@ramfox ramfox force-pushed the x-hp-derp-tls-debug branch from 33e2c52 to aaa7979 Compare June 13, 2023 20:54
Copy link
Collaborator

@Arqu Arqu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🐰

Copy link
Collaborator

@Arqu Arqu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🐰 🐰

@ramfox ramfox merged commit 6f40e14 into main Jun 13, 2023
@ramfox ramfox deleted the x-hp-derp-tls-debug branch June 13, 2023 21:14
matheus23 pushed a commit that referenced this pull request Nov 14, 2024
Add TLS certificates & dialing via https in the derper and `hp::derp::http::client::Client`.

Refactor to add a `hp::derp::http::server::Server` that optionally serves the derp code on HTTP or HTTPS depending on the configuration.

Refactor the derper and any derp server tests to use the `hp::derp::http::server::Server`.

Refactor DNS resolving to have one core resolver.

Close the derp server and derper gracefully using `ctrl-c`.

Adds more instrumentation to the derp server processes.

Changes the default derp server hostname to `derp.iroh.network`

---------

Co-authored-by: dignifiedquire <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

TLS Support in Derp
4 participants