ref: remove unneeded async #1021
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
no real async fns are being called from inside the netcheck actor.
flub
approved these changes
May 16, 2023
dignifiedquire
approved these changes
May 16, 2023
dignifiedquire
added a commit
that referenced
this pull request
May 16, 2023
* fix: process incoming IP packets in a seperate task This fixes receiving STUN packets during an endpoint update. Before they processing of incoming STUN packets would be interrupted due to the main actor loop waiting on the endpoint update. * ref: remove unneeded async (#1021) no real async fns are being called from inside the netcheck actor. * fmt --------- Co-authored-by: Rüdiger Klaehn <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
no real async fns are being called from inside the netcheck actor.