You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Thank you for creating this library—it's been very helpful.
I noticed that the absolute filename of a migration is currently saved to the database. This setup means a rollback can only be performed from the same machine that executed the migration, or one with a similar directory structure.
Wouldn't it be more flexible to store the path relative to migrationsDir? This change would allow rollbacks from any machine. If you're open to PRs, I’d be happy to contribute one.
I think you are totally right and this is a design flaw I made. The only thing that worries me a bit about this change is that it will be a breaking change, no?
Maybe we can implement a command to migrate the paths and make it easier for users, WDYT?
Yeah, I think implementing that command is a great idea. I've opened a pull request which implements the changes here: #123. I'm currently looking into the tests now.
Hi @mycodeself,
Thank you for creating this library—it's been very helpful.
I noticed that the absolute filename of a migration is currently saved to the database. This setup means a rollback can only be performed from the same machine that executed the migration, or one with a similar directory structure.
Wouldn't it be more flexible to store the path relative to migrationsDir? This change would allow rollbacks from any machine. If you're open to PRs, I’d be happy to contribute one.
Thanks for considering this improvement.
Cheers,
@jdachtera
The text was updated successfully, but these errors were encountered: