Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EPL multiple combination of copyright owners #119

Closed
skabashnyuk opened this issue Sep 23, 2016 · 6 comments
Closed

EPL multiple combination of copyright owners #119

skabashnyuk opened this issue Sep 23, 2016 · 6 comments
Labels
is:enhancement Enhancement to an existing feature todo Accepted items from the backlog which can be worked on

Comments

@skabashnyuk
Copy link

Hello
I'm a Eclipse Che developer and I have one question related to license check
EPL looks like this.

/*******************************************************************************
 * Copyright (c) {DATE} {INITIAL COPYRIGHT OWNER} {OTHER COPYRIGHT OWNERS}.
 * All rights reserved. This program and the accompanying materials
 * are made available under the terms of the Eclipse Public License v1.0
 * which accompanies this distribution, and is available at
 * http://www.eclipse.org/legal/epl-v10.html
 *
 * Contributors:
 *    {INITIAL AUTHOR} - initial API and implementation and/or initial documentation
 *    {Second AUTHOR} - Dev API
 *******************************************************************************/

Until some time we have one or two copyright owners.
I've managed this with different templates and with configuration of individual maven
modules. In the case if one module contains several owners we just exclude files
with different owners. Now situation become complex.
So I need to have ability to correctly manage several combination of owners in single module
Ideally without plugin configuration change.
Any ideas how to achieve that.

@TylerJewell
Copy link

** bump **

@cvgaviao
Copy link

Well, I have not tried yet, but I think you can achieve this declaring the properties configuration and set all the owners in a pom properties:

<properties>
    <owner>${license.copyrightOwners}</owner>
</properties>

@skabashnyuk
Copy link
Author

It works if one module contains sources with a single list of license.copyrightOwners. My problem and the goal of this issue to solve situation if single module contains different sources with different combination of copyrightOwners

@flefevre
Copy link

flefevre commented Dec 6, 2017

Do you have found any solution?

@mathieucarbou
Copy link
Owner

@skabashnyuk : how could the plugin determine per file which authors to put in a header ?
The request is nice but I don't see how it could be easily implemented without providing some mapping somewhere...
If such use cases are limited in your code-base, you can exclude the files from license maven plugin and manage the headers yourself perhaps ?

@mathieucarbou mathieucarbou added is:enhancement Enhancement to an existing feature todo Accepted items from the backlog which can be worked on labels Feb 6, 2019
@skabashnyuk
Copy link
Author

how could the plugin determine per file which authors to put in a header ?

In our case https://github.com/eclipse/che. One of the trickiest situations was if
there is a jar that contains a lot of files and majority of the classes have one set of authors
however ~10-20 has two or three others. Having individual configuration will look complex.
Putting all that files to ignore(what we are doing right now) has some disadvantiages - like skiping
license check in future, not automatically update of years.

I would say this task should be separate on two distinct topics.

  1. How to generate a new header.
    For this case, we may reuse the current approach.
  2. How to check existed header.
    I would say we should be able to explain in the template that some additional characters may happen here and license
    the plugin should not fail if it saw something.

the first thing that comes to mind something like this:

Copyright (c) ${license.git.copyrightYears} ${h_copyrightOwner}*
This program and the accompanying materials are made
available under the terms of the Eclipse Public License 2.0
which is available at https://www.eclipse.org/legal/epl-2.0/

SPDX-License-Identifier: EPL-2.0

Contributors:
  ${h_contributor}*

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
is:enhancement Enhancement to an existing feature todo Accepted items from the backlog which can be worked on
Projects
None yet
Development

No branches or pull requests

5 participants