Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upcoming releases? #21

Open
michaelmarchesi opened this issue Aug 13, 2019 · 3 comments
Open

Upcoming releases? #21

michaelmarchesi opened this issue Aug 13, 2019 · 3 comments

Comments

@michaelmarchesi
Copy link

michaelmarchesi commented Aug 13, 2019

Hello @gavinlove ,

We used the dev-master branch in PHPUnit 7 and saw an increase in performance and would like to know if there are any planned releases. We previously used PHPUnit 5.7 and are upgrading to PHPUnit 7 and would like to have this package available for use.

@gavinlove
Copy link
Member

Do you have any numbers on the increase? We saw almost no difference when we last tested it with PHPUnit 7

@michaelmarchesi
Copy link
Author

With the accelerator: 7-8 minutes using roughly 325mb memory
without accelerator: 15-17 minutes, 1.34gb memory
Our functional tests benefited the most from the accelerator.

@dontub
Copy link

dontub commented Aug 20, 2019

As PHPUnit destructs instances of the test classes only at the end of the complete test process the accelerator should still make sense if the test classes have no tearDown() that sets the properties to null -- at least in regard to memory consumption.

Since we have implementations of tearDown() that set properties to null that use the most memory the improvement with the accelerator in regard to memory is only 10 MB (ca. 700 vs 710), while the execution time is slightly increased probably because of the listener code that is executed after every test.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

3 participants