Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bump go-gitlab version, bump golang version for make dev-env #670

Merged
merged 3 commits into from
Jun 26, 2023
Merged

bump go-gitlab version, bump golang version for make dev-env #670

merged 3 commits into from
Jun 26, 2023

Conversation

jasonwliu
Copy link
Contributor

  • Bumps go-gitlab to a version that fixes the type of system_output
  • Update the golang version for make dev-env to v1.20

Closes #669.

@coveralls
Copy link

Coverage Status

coverage: 75.273% (-0.04%) from 75.317% when pulling e20324a on jasonwliu:fix-failed-test-reports into a894122 on mvisonneau:main.

@jasonwliu
Copy link
Contributor Author

jasonwliu commented Jun 12, 2023 •
edited
Loading

Had to change a test because Compare is now returning a nil for err.

@jasonwliu jasonwliu mentioned this pull request Jun 12, 2023
Merged
@mvisonneau mvisonneau self-assigned this Jun 26, 2023
@mvisonneau mvisonneau added the enhancement New feature or request label Jun 26, 2023
@mvisonneau
Copy link
Owner

thanks @jasonwliu !

@mvisonneau mvisonneau merged commit 0c231c2 into mvisonneau:main Jun 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@mvisonneau mvisonneau

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Test reports metrics aren't available for failing pipelines
3 participants
@jasonwliu @coveralls @mvisonneau