Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pipeline Status - Passed with Warnings #123

Open
jayyzhao opened this issue Jun 25, 2020 · 3 comments
Open

Pipeline Status - Passed with Warnings #123

jayyzhao opened this issue Jun 25, 2020 · 3 comments
Labels
enhancement New feature or request

Comments

@jayyzhao
Copy link

Great stuff love the work. An enhancement would be able to include the differentiation of status Passed/Successful with Passed with Warning.

@mvisonneau
Copy link
Owner

thanks for kind feedback @jayyzhao! Indeed, I reckon it would be possible by matching out if the job was manual or not 🤔

@mvisonneau mvisonneau added the enhancement New feature or request label Jun 29, 2020
@tewfik-ghariani
Copy link

Based on https://gitlab.com/gitlab-org/gitlab/-/issues/229137 , maybe it is possible to perform a request to the pipeline itself and look for the detailed_status block that will represent the case when a pipeline passed with warnings

@armingerten
Copy link

Given that there is already an individual API call for each pipeline, the status metric could be based on the detailed_status as suggested by @tewfik-ghariani . So instead of

return Pipeline{
ID: gp.ID,
Coverage: coverage,
Timestamp: timestamp,
DurationSeconds: float64(gp.Duration),
QueuedDurationSeconds: float64(gp.QueuedDuration),
Status: gp.Status,
}

this could be something like this:

return Pipeline{
	ID:                    gp.ID,
	Coverage:              coverage,
	Timestamp:             timestamp,
	DurationSeconds:       float64(gp.Duration),
	QueuedDurationSeconds: float64(gp.QueuedDuration),
//	Status:                gp.DetailedStatus.Group,
	Status:                gp.DetailedStatus.Text,
}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

4 participants