Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add broad line support #34

Open
multiwavelength opened this issue Jun 3, 2022 · 1 comment
Open

Add broad line support #34

multiwavelength opened this issue Jun 3, 2022 · 1 comment
Labels
enhancement New feature or request

Comments

@multiwavelength
Copy link
Owner

At the moment, gleam works really well for narrow emission lines (such as those associated with narrow-line regions in AGN and star-forming regions). This is because the starting solution for the Gaussian fits is set to the resolution of the instruments. This starting solution also works for broad lines (>500 km/s), as long as the line is well separated from other lines and the fit is simple. However, the fits do not converge to the correct solution when one has both broad and narrow components of the same emission line. To fix this, we should give users the option to label lines in the spectral lines list as broad and provide a different starting solution for the Gaussian fits, in line with expectations for broad lines (i.e. a FWHM starting solution equivalent to 500-1000 km/s)

@multiwavelength multiwavelength added the enhancement New feature or request label Jun 3, 2022
@multiwavelength
Copy link
Owner Author

I quickly tested this and it works BEAUTIFULLY.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant