-
Notifications
You must be signed in to change notification settings - Fork 208
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make CID versions multicodecs #49
Comments
@diasdavid and I discussed this offline but I figured it should be posted here to keep things public. We and came across the theoretical problem of handling non-multibase CIDv18 (18 = 0x12 = SHA2-256 multicodec) and decided that we could just skip that or define CIDv0 = CIDv18. |
Is there a way to get this moving? Are there any blockers that need to be discussed? I'm currently in the process of drafting our new format for rlay-project/rlay-ontology, which strongly revolves around CIDs. |
I think the next step to move this forward is to open a PR against table.csv to add something like
I'm still not clear on why #94 is necessarily a different thing though tbh. It seems to be part of the same bundle of concerns and just a matter of definitions. |
#94 is proposing adding a new multicodec for CIDs. So a multicodec-identified CID would be |
Hey @Stebalien @rvagg I'm happy to create the PRs needed to help move this forward, as I'm interested in using multicodec similarly to CIDs without it causing conflicts. Is there anything I need to be aware of in terms of the two different options? (to me your approach @Stebalien makes the most sense) |
I believe all we need is two PRs:
|
This way, we can trivially disambiguate CIDs from, e.g., raw multihashes.
(To do this, we'd need to steal 0x1 from unary for CIDv1).
The text was updated successfully, but these errors were encountered: