Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[fields][TimeField] Adapt delta calculation for meridiem #13213

Closed
arthurbalduini opened this issue May 22, 2024 · 1 comment · Fixed by #13310
Closed

[fields][TimeField] Adapt delta calculation for meridiem #13213

arthurbalduini opened this issue May 22, 2024 · 1 comment · Fixed by #13310
Assignees
@arthurbalduini
Labels
accessibility a11y bug 🐛 Something doesn't work component: pickers This is the name of the generic UI component, not the React module! enhancement This is not a bug, nor a new feature feature: Keyboard editing Related to the pickers keyboard edition

Comments

@arthurbalduini
Copy link
Member

arthurbalduini commented May 22, 2024 •
edited
Loading

Current behavior

When the meridian value is either empty (aa) or AM, pressing PageDown will make it switch between aa and AM due to the logic on the newOptionsIndex used to adjust letter sections. It's not the case for PageUp nor when the value is PM , plus the digit sections behave differently, never resetting again their section value.

Screen.Recording.2024-05-22.at.11.01.23.mov

Desired behavior

Should not reset placeholder value in meridians

Search keywords: pickers, sections, A11y, accessibility
@arthurbalduini arthurbalduini added accessibility a11y component: pickers This is the name of the generic UI component, not the React module! enhancement This is not a bug, nor a new feature feature: Keyboard editing Related to the pickers keyboard edition labels May 22, 2024
@arthurbalduini arthurbalduini changed the title [Pickers] Refactor meridian's keyboard support for PageUp and PageDown [Pickers] Refactor keyboard support for PageUp and PageDown on 'letter' type sections May 22, 2024
@arthurbalduini arthurbalduini changed the title [Pickers] Refactor keyboard support for PageUp and PageDown on 'letter' type sections [Pickers] Refactor keyboard support for PageUp and PageDown May 22, 2024
@LukasTy LukasTy changed the title [Pickers] Refactor keyboard support for PageUp and PageDown [pickers] Refactor keyboard support for PageUp and PageDown May 23, 2024
@LukasTy LukasTy changed the title [pickers] Refactor keyboard support for PageUp and PageDown [fields] Refactor keyboard support for PageUp and PageDown May 28, 2024
@arthurbalduini arthurbalduini added the bug 🐛 Something doesn't work label May 28, 2024
@arthurbalduini arthurbalduini changed the title [fields] Refactor keyboard support for PageUp and PageDown [fields][TimeField] Adapts delta calculation for meridian May 28, 2024
@LukasTy LukasTy changed the title [fields][TimeField] Adapts delta calculation for meridian [fields][TimeField] Adapt delta calculation for meridiem May 29, 2024
@arthurbalduini arthurbalduini self-assigned this May 30, 2024
@arthurbalduini arthurbalduini mentioned this issue May 30, 2024
Merged
1 task
@github-actions GitHub Actions
Copy link

github-actions bot commented Jun 6, 2024

⚠️ This issue has been closed. If you have a similar problem but not exactly the same, please open a new issue.
Now, if you have additional information related to this issue or things that could help future readers, feel free to leave a comment.

@arthurbalduini: How did we do? Your experience with our support team matters to us. If you have a moment, please share your thoughts in this short Support Satisfaction survey.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@arthurbalduini arthurbalduini

Labels
accessibility a11y bug 🐛 Something doesn't work component: pickers This is the name of the generic UI component, not the React module! enhancement This is not a bug, nor a new feature feature: Keyboard editing Related to the pickers keyboard edition
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[fields] Fix new index calculation on letter section arthurbalduini/mui-x
1 participant
@arthurbalduini